Add SM3 in wolfSSL_HmacCopy #9190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
Hi @colmenero Excellent, thanks! wolfSSL requires a signed contributor agreement on file to accept third party changes. Could you please send an email to support@wolfssl.com? I can help get you set up as a contributor from there. Thanks, |
Contributor
|
Okay to test |
This was referenced Sep 12, 2025
SparkiDev
approved these changes
Sep 15, 2025
Contributor
Author
|
Update: Thanks for the approval, I'm currently coordinating with my company's legal department to verify that I can sign the contributor agreement. |
Contributor
|
retest this please |
Member
|
Contributor agreement received |
Member
|
Retest this please Jenkins. Test results were purged for failing PRB-master-job, need to regenerate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SM3 algorithm is missing in the
wolfSSL_HmacCopyfunctionality. This causes #9187.Testing
I didn't find any tests for
wolfSSL_HmacCopyso I only did a manual verification with the reproducer that I had for #9187. The output of the SM3 HMAC matches the one that I get with this online calculator.Let me know if I should add automatic testing or documentation.
Checklist